Move heavy getUserDeviceKeys processing off the UI thread#2328
Open
Azare77 wants to merge 1 commit into
Open
Conversation
Offloaded the expensive parts of getUserDeviceKeys to a background isolate to prevent main thread blocking during key loading and parsing. This fixes UI freezes/stutters caused by synchronous processing of large device key datasets.
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2328 +/- ##
==========================================
+ Coverage 55.32% 58.05% +2.73%
==========================================
Files 160 160
Lines 19854 19876 +22
==========================================
+ Hits 10984 11539 +555
+ Misses 8870 8337 -533
... and 26 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the expensive processing inside getUserDeviceKeys
to a background isolate to avoid blocking the main/UI thread.
Large device key datasets previously caused noticeable UI freezes
during startup and sync operations.
Changes: